[FFmpeg-devel] [PATCH 05/17] Use -Bsymbolic for shared libs only, not executables (original) (raw)
Måns Rullgård mans
Wed Jan 19 21:54:53 CET 2011
- Previous message: [FFmpeg-devel] [PATCH 05/17] Use -Bsymbolic for shared libs only, not executables
- Next message: [FFmpeg-devel] [PATCH 06/17] cpu-test: include stdio.h only for test prog
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
V?ctor Paesa writes:
Hi,
2011/1/18 M?ns Rullg?rd: Janne Grunau writes:
On Tue, Jan 18, 2011 at 07:32:09PM +0000, Mans Rullgard wrote: Some linkers fail if this flag is used when creating an executable file. Since the flag is meaningful only for shared libraries, dropping it from the main link flags is correct. --- ?configure | ? ?2 +- ?1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure b/configure index 7cd80fd..6100419 100755 --- a/configure +++ b/configure @@ -2899,7 +2899,7 @@ enabled extrawarnings && checkcflags -Winline ?checkldflags -Wl,--warn-common ?checkldflags -Wl,--as-needed ?checkldflags '-Wl,-rpath-link,$(BUILDROOT)/libpostproc -Wl,-rpath-link,$(BUILDROOT)/libswscale -Wl,-rpath-link,$(BUILDROOT)/libavfilter -Wl,-rpath-link,$(BUILDROOT)/libavdevice -Wl,-rpath-link,$(BUILDROOT)/libavformat -Wl,-rpath-link,$(BUILDROOT)/libavcodec -Wl,-rpath-link,$(BUILDROOT)/libavcore -Wl,-rpath-link,$(BUILDROOT)/libavutil' -checkldflags -Wl,-Bsymbolic +testldflags -Wl,-Bsymbolic && append SHFLAGS -Wl,-Bsymbolic ?echo "X{};" > $TMPV ?if testldflags -Wl,--version-script,$TMPV; then ok Queued. out of curiousity which linker is this? IRIX IIRC. ?It's not an important platform, but the change is logically correct regardless. -Bsymbolic is an ELF flag. most PE linkers warn on that (but don't fail)
IRIX uses ELF, but the flag makes no sense when creating an executable (rather than a shared object), and the IRIX linker considers this an error while the GNU linker simply ignores it.
-- M?ns Rullg?rd mans at mansr.com
- Previous message: [FFmpeg-devel] [PATCH 05/17] Use -Bsymbolic for shared libs only, not executables
- Next message: [FFmpeg-devel] [PATCH 06/17] cpu-test: include stdio.h only for test prog
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]