Dorit Naishlos - [patch] tiny cleanup in tree-vectorizer.c (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

A couple cleanups to 'vect_is_simple_reduction()' in tree-vectorizer.c:

  1. The function arguments are marked as ATTRIBUTE_UNUSED but are actually used in the function (I first committed an empty implementation of this function (on June 5th), and then added the actual implementation (on June 16th), and apparently left the ATTRIBUTE_UNUSED marks).

  2. Call swap_tree_operands to swap operands (instead of looping through the uses).

Thanks to Daniel Berlin who pointed these out.

Bootstrapped and tested on powerpc-linux

ok to commit?

thanks, dorit

:ADDPATCH SSA (vectorizer):

ChangeLog:

    * tree-ssa-operands.c (swap_tree_operands): Export.
    * tree.h (swap_tree_operands): Declare.
    * tree-vectorizer.c (vect_is_simple_reduction): Remove

ATTRIBUTE_UNUSED. Call swap_tree_operands.

Patch:

(See attached file: clean.diff.txt)

Attachment:clean.diff.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]