Andrew Haley - Re: [Patch] PR java/21418: Order of files on command line matters while (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

• From: Andrew Haley
• To: Ranjit Mathew
• Cc: GCJ Patches , GCC Patches , mark at klomp dot org
• Date: Wed, 21 Sep 2005 13:15:16 +0100
• Subject: Re: [Patch] PR java/21418: Order of files on command line matters while resolving inheritance
• References: <43312D9C.4090105@gmail.com><17201.12613.295312.297706@zapata.pink><39399b9d050921032649fb4c72@mail.gmail.com><17201.14379.929777.481509@zapata.pink><39399b9d05092103427cd9336e@mail.gmail.com><17201.15256.966422.340437@zapata.pink><39399b9d05092104442b7de4bb@mail.gmail.com>

Ranjit Mathew writes:

On 9/21/05, Andrew Haley aph@redhat.com wrote:

But the code you've added seems to be duplicating some of the logic in maybe_layout_super_class(). Why not simply call that function? [...]

Or do you mean something like simply:

type1 = maybe_layout_super_class (CLASSTYPE_SUPER (type1), type1);

?

Yes.

OK, how about the attached patch? It was tested again by doing a clean build of libjava followed by a testsuite run (including Jacks).

Yes, thanks.

Andrew.

• References:
  • [Patch] PR java/21418: Order of files on command line matters whileresolving inheritance
    * From: Ranjit Mathew
  • Re: [Patch] PR java/21418: Order of files on command line matters whileresolving inheritance
    * From: Andrew Haley
  • Re: [Patch] PR java/21418: Order of files on command line matters while resolving inheritance
    * From: Ranjit Mathew
  • Re: [Patch] PR java/21418: Order of files on command line matters while resolving inheritance
    * From: Andrew Haley
  • Re: [Patch] PR java/21418: Order of files on command line matters while resolving inheritance
    * From: Ranjit Mathew
  • Re: [Patch] PR java/21418: Order of files on command line matters while resolving inheritance
    * From: Andrew Haley
  • Re: [Patch] PR java/21418: Order of files on command line matters while resolving inheritance
    * From: Ranjit Mathew