[PATCH 1/1] drm/exynos: Fix build error in exynos_hdmi.c (original) (raw)

Sean Paul seanpaul at chromium.org
Mon Feb 3 15:35:32 PST 2014

On Mon, Feb 3, 2014 at 7:14 AM, Inki Dae <inki.dae at samsung.com> wrote:

2014-01-31 Josh Boyer <jwboyer at fedoraproject.org>:

On Fri, Jan 31, 2014 at 1:09 AM, Sachin Kamat <sachin.kamat at linaro.org> wrote:

'hdmiinfoframe' is already defined in include/linux/hdmi.h. Rename the local variable to avoid the following build error: drivers/gpu/drm/exynos/exynoshdmi.c:382:8: error: 'hdmiinfoframe' defined as wrong kind of tag struct hdmiinfoframe {

Signed-off-by: Sachin Kamat <sachin.kamat at linaro.org> Reported-by: Josh Boyer <jwboyer at fedoraproject.org> This does fix the build error I saw. I don't have hardware to test the results with, but it now compiles correctly. Thanks for the quick turn around! Hi, Thanks for report and patch. But Sean posted already below patch, [PATCH v4 01/34] drm/exynos: Rename hdmiinfoframe to avoid collision

Yeah, sorry, I just tucked it in with the rest of my stuff :)

Sean

Thanks, Inki Dae

josh

--- drivers/gpu/drm/exynos/exynoshdmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynoshdmi.c b/drivers/gpu/drm/exynos/exynoshdmi.c index a0e10ae..0d4407c 100644 --- a/drivers/gpu/drm/exynos/exynoshdmi.c +++ b/drivers/gpu/drm/exynos/exynoshdmi.c @@ -379,7 +379,7 @@ static const struct hdmiphyconfig hdmiphyv14configs[] = { }, }; -struct hdmiinfoframe { +struct hdmiframeinfo { enum HDMIPACKETTYPE type; u8 ver; u8 len; @@ -682,7 +682,7 @@ static u8 hdmichksum(struct hdmicontext *hdata, } static void hdmireginfoframe(struct hdmicontext *hdata, - struct hdmiinfoframe *infoframe) + struct hdmiframeinfo *infoframe) { u32 hdrsum; u8 chksum; @@ -985,7 +985,7 @@ static void hdmiconfreset(struct hdmicontext *hdata) static void hdmiconfinit(struct hdmicontext *hdata) { - struct hdmiinfoframe infoframe; + struct hdmiframeinfo infoframe; /* disable HPD interrupts from HDMI IP block, use GPIO instead */ hdmiregwritemask(hdata, HDMIINTCCON, 0, HDMIINTCENGLOBAL | -- 1.7.9.5

dri-devel mailing list dri-devel at lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

dri-devel mailing list dri-devel at lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

More information about the dri-devel mailing list