[PATCH v3 5/5] ASoC: tda998x: adjust the audio CTS_N pre-divider from audio format (original) (raw)
Mark Brown broonie at kernel.org
Tue Feb 4 10:09:22 PST 2014
- Previous message: [alsa-devel] [PATCH v3 4/5] ASoC: tda998x: adjust the audio hw parameters from EDID
- Next message: [Bug 73848] [Radeon] Blank screen after boot with kernel 3.12.x, xorg 1.15
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Thu, Jan 30, 2014 at 12:08:06PM +0100, Jean-Francois Moine wrote:
- if (format == p->audioformat) { + if (format == p->audioformat && + paramsformat(params) == priv->audiosampleformat) { regwrite(priv, REGENAAP, p->audiocfg); return;
I find the above confusing and probably deserving of a comment explaining the logic. I think it's trying to skip noop configuration updates?
} p->audioformat = format; + priv->audiosampleformat = paramsformat(params);
You should be using params_width() for the number of bits per sample. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140204/2983dfe7/attachment-0001.pgp>
- Previous message: [alsa-devel] [PATCH v3 4/5] ASoC: tda998x: adjust the audio hw parameters from EDID
- Next message: [Bug 73848] [Radeon] Blank screen after boot with kernel 3.12.x, xorg 1.15
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]