[PATCH RFC 1/2] drivers/base: permit base components to omit the bind/unbind ops (original) (raw)

Russell King - ARM Linux linux at arm.linux.org.uk
Fri Feb 7 09:34:07 PST 2014

On Fri, Feb 07, 2014 at 04:55:00PM +0100, Jean-Francois Moine wrote:

Some simple components don't need to do any specific action on bind to / unbind from a master component.

This patch permits such components to omit the bind/unbind operations. Signed-off-by: Jean-Francois Moine <moinejf at free.fr> --- drivers/base/component.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/base/component.c b/drivers/base/component.c index c53efe6..0a39d7a 100644 --- a/drivers/base/component.c +++ b/drivers/base/component.c @@ -225,7 +225,8 @@ static void componentunbind(struct component *component, { WARNON(!component->bound); - component->ops->unbind(component->dev, master->dev, data); + if (component->ops) + component->ops->unbind(component->dev, master->dev, data); component->bound = false; /* Release all resources claimed in the binding of this component */ @@ -274,7 +275,11 @@ static int componentbind(struct component *component, struct master *master, devdbg(master->dev, "binding %s (ops %ps)\n", devname(component->dev), component->ops); - ret = component->ops->bind(component->dev, master->dev, data); + if (component->ops) + ret = component->ops->bind(component->dev, master->dev, data); + else + ret = 0; +

NAK. If this is done, there's absolutely no point to this code.

-- FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. Estimate before purchase was "up to 13.2Mbit".

More information about the dri-devel mailing list