[RFC PATCH 2/3] staging: imx-drm-core: Use graph to find connection between crtc and encoder (original) (raw)
Dan Carpenter dan.carpenter at oracle.com
Tue Feb 11 00:38:31 PST 2014
- Previous message: [RFC PATCH 2/3] staging: imx-drm-core: Use graph to find connection between crtc and encoder
- Next message: [RFC PATCH 2/3] staging: imx-drm-core: Use graph to find connection between crtc and encoder
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Why is this loop soo complicated? Why do you need to mess around with this "lastep" stuff - you don't actually end up using it.
The loop reduces down to this without comments: for (i = 0; !ret; i++) { ^^^^ Philipp, "ret" isn't set anymore in the new loop.
uint32t mask;
ep = v4l2ofgetnextendpoint(np, lastep); if (!ep) break; /* CSI */ mask = imxdrmfindcrtcmask(imxdrm, ep); ofnodeput(ep); if (mask == 0) return -EPROBEDEFER; crtcmask |= mask; }
regards, dan carpenter
- Previous message: [RFC PATCH 2/3] staging: imx-drm-core: Use graph to find connection between crtc and encoder
- Next message: [RFC PATCH 2/3] staging: imx-drm-core: Use graph to find connection between crtc and encoder
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]