drm/msm: CONFIG_MSM_OCMEM? (original) (raw)

Paul Bolle pebolle at tiscali.nl
Tue Feb 11 12:00:02 PST 2014

On Tue, 2014-02-11 at 12:29 -0500, Rob Clark wrote:

On Tue, Feb 11, 2014 at 10:39 AM, Paul Bolle <pebolle at tiscali.nl> wrote: > Commit 55459968176f ("drm/msm: add a330/apq8x74") added preprocessor > checks for CONFIGMSMOCMEM. But I couldn't find a Kconfig symbol > MSMOCMEM (nor a preprocessor define for a macro of that name). Why were > those preprocessor checks added?

At the moment, CONFIGMSMOCMEM is only in downstream kernel.. not 100% sure about how we'll handle that upstream when there is more than just drm/msm using OCMEM (which can be shared between gpu, video enc/dec, etc).

I see. (Wouldn't that be an upstream kernel, actually?)

> Please note that lines 197-201 currently read: > /* Set the OCMEM base address for A330, etc */ > if (a3xxgpu->ocmemhdl) { > gpuwrite(gpu, REGA3XXRBGMEMBASEADDR, > (unsigned int)(a3xxgpu->ocmembase >> 14)); > } > > ocmemhdl and ocmembase are used uninitialized here, aren't they? So it > seems these lines should be wrapped with a preprocessor check for > CONFIGMSMOCMEM too.

in this case ocmemhdl will be NULL (since a3xxgpu is kzalloc'd). The #ifdef's could be added here, but not required.

I missed that. So whether or not to #ifdef this would be mostly a matter of style.

Thanks,

Paul Bolle

More information about the dri-devel mailing list