[PATCH v5 1/1] drm/i915: Add 180 degree primary plane rotation support (original) (raw)

Daniel Vetter daniel.vetter at ffwll.ch
Tue Feb 11 14:06:09 PST 2014

On Tue, Feb 11, 2014 at 11:59 AM, <sagar.a.kamble at intel.com> wrote:

From: Sagar Kamble <sagar.a.kamble at intel.com>

Primary planes support 180 degree rotation. Expose the feature through rotation drm property. v2: Calculating linear/tiled offsets based on pipe source width and height. Added 180 degree rotation support in ironlakeupdateplane. v3: Checking if CRTC is active before issueing updateplane. Added wait for vblank to make sure we dont overtake page flips. Disabling FBC since it does not work with rotated planes. v4: Updated rotation checks for pending flips, fbc disable. Creating rotation property only for Gen4 onwards. Property resetting as part of lastclose. v5: Resetting property in i915driverlastclose properly for planes and crtcs. Fixed linear offset calculation that was off by 1 w.r.t width in i9xxupdateplane and ironlakeupdateplane. Removed tab based indentation and unnecessary braces in intelcrtcsetproperty and intelupdatefbc. FBC and flip related checks should be done only for valid crtcs. Cc: Daniel Vetter <daniel.vetter at ffwll.ch> Cc: Jani Nikula <jani.nikula at linux.intel.com> Cc: David Airlie <airlied at linux.ie> Cc: dri-devel at lists.freedesktop.org Cc: linux-kernel at vger.kernel.org Cc: vijay.a.purushothaman at intel.com Signed-off-by: Uma Shankar <uma.shankar at intel.com> Signed-off-by: Sagar Kamble <sagar.a.kamble at intel.com>

Process nit: Since you have a nice testcase for this, please add a reference to it using the testcase tag in the cc/sob section here, e.g.

Testcase: igt/kms_plane_rotation_crc

Thanks, Daniel

Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

More information about the dri-devel mailing list