[PATCH v6 1/1] drm/i915: Add 180 degree primary plane rotation support (original) (raw)

Chris Wilson chris at chris-wilson.co.uk
Wed Feb 12 06:02:24 PST 2014

On Wed, Feb 12, 2014 at 12:22:00PM +0530, sagar.a.kamble at intel.com wrote:

From: Sagar Kamble <sagar.a.kamble at intel.com>

Primary planes support 180 degree rotation. Expose the feature through rotation drm property. v2: Calculating linear/tiled offsets based on pipe source width and height. Added 180 degree rotation support in ironlakeupdateplane. v3: Checking if CRTC is active before issueing updateplane. Added wait for vblank to make sure we dont overtake page flips. Disabling FBC since it does not work with rotated planes. v4: Updated rotation checks for pending flips, fbc disable. Creating rotation property only for Gen4 onwards. Property resetting as part of lastclose. v5: Resetting property in i915driverlastclose properly for planes and crtcs. Fixed linear offset calculation that was off by 1 w.r.t width in i9xxupdateplane and ironlakeupdateplane. Removed tab based indentation and unnecessary braces in intelcrtcsetproperty and intelupdatefbc. FBC and flip related checks should be done only for valid crtcs. v6: Minor nits in FBC disable checks for comments in intelcrtcsetproperty and positioning the disable code in intelupdatefbc. Testcase: igt/kmsplanerotationcrc

I particularly enjoyed how it reports an error after successfully changing rotation modes. It could use with a few DRM_DEBUG_KMS() to highlight what is hanppening. -Chris

-- Chris Wilson, Intel Open Source Technology Centre

More information about the dri-devel mailing list