[PATCH 0/5] drm/i915: Full pipe rotation & rotation property name bikeshedding (original) (raw)
ville.syrjala at linux.intel.com ville.syrjala at linux.intel.com
Wed Feb 12 13:14:59 PST 2014
- Previous message: [Intel-gfx] [PATCH 1/6] drm: export cmdline and preferred mode functions from fb helper
- Next message: [PATCH 1/5] drm: Pass name to drm_rotation_property_create()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
From: Ville Syrjälä <ville.syrjala at linux.intel.com>
After playing around Sagar's primary plane rotation a bit, I decided that extending that to full pipe rotation would be nice. Chris also seemed to want that, but I'm not sure he does anymore :) But then I decided it's so easy to implement that I can't leave it hanging. So here it is.
The biggest topic for discussion here should be the property names. I'm now proposing the following:
- drm_plane "rotation" -> rotates only the specific plane
- drm_crtc "plane-rotation" -> rotates only the crtc primary plane
- drm_crtc "cursor-rotation" -> rotates only the crtc cursor plane
- drm_crtc "rotation" -> rotates the entire crtc ie. effectively the rotation happens after all planes have been blended together
Once we get to the fancy new world where everything is a drm_plane, we can start ignoring the "plane-rotation" and "cursor-rotation" properties.
Any input on the names is appreciated.
Ville Syrjälä (5): drm: Pass name to drm_rotation_property_create() drm/i915: Rename primary plane rotation property to "plane-rotation" drm: Add drm_rotation_chain() drm/i915: Add rotation support for the cursor plane drm/i915: Add full pipe rotation
drivers/gpu/drm/drm_crtc.c | 45 ++++++- drivers/gpu/drm/i915/i915_dma.c | 26 ++++- drivers/gpu/drm/i915/i915_drv.h | 4 +- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_display.c | 219 ++++++++++++++++++++++++++++------- drivers/gpu/drm/i915/intel_drv.h | 4 +- drivers/gpu/drm/i915/intel_pm.c | 6 +- drivers/gpu/drm/i915/intel_sprite.c | 23 +++- drivers/gpu/drm/omapdrm/omap_plane.c | 2 +- include/drm/drm_crtc.h | 3 + 10 files changed, 277 insertions(+), 56 deletions(-)
-- 1.8.3.2
- Previous message: [Intel-gfx] [PATCH 1/6] drm: export cmdline and preferred mode functions from fb helper
- Next message: [PATCH 1/5] drm: Pass name to drm_rotation_property_create()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]