[PATCH 1/5] drm: Pass name to drm_rotation_property_create() (original) (raw)

Sagar Arun Kamble sagar.a.kamble at intel.com
Thu Feb 13 02:42:06 PST 2014

Reviewed-by: Sagar Kamble <sagar.a.kamble at intel.com>

On Wed, 2014-02-12 at 23:15 +0200, ville.syrjala at linux.intel.com wrote:

From: Ville Syrjälä <ville.syrjala at linux.intel.com>

Allow rotation properties to have custom names. TODO: maybe squash into "drm: Add drmmodecreaterotationproperty()" Cc: Sagar Kamble <sagar.a.kamble at intel.com> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com> --- drivers/gpu/drm/drmcrtc.c | 3 ++- drivers/gpu/drm/i915/inteldisplay.c | 2 +- drivers/gpu/drm/i915/intelsprite.c | 2 +- drivers/gpu/drm/omapdrm/omapplane.c | 2 +- include/drm/drmcrtc.h | 1 + 5 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drmcrtc.c b/drivers/gpu/drm/drmcrtc.c index fe04889..7077676 100644 --- a/drivers/gpu/drm/drmcrtc.c +++ b/drivers/gpu/drm/drmcrtc.c @@ -4179,6 +4179,7 @@ void drmmodeconfigcleanup(struct drmdevice *dev) EXPORTSYMBOL(drmmodeconfigcleanup); struct drmproperty *drmmodecreaterotationproperty(struct drmdevice *dev, + const char *name, unsigned int supportedrotations) { static const struct drmpropenumlist props[] = { @@ -4190,7 +4191,7 @@ struct drmproperty *drmmodecreaterotationproperty(struct drmdevice *dev, { DRMREFLECTY, "reflect-y" }, }; - return drmpropertycreatebitmask(dev, 0, "rotation", + return drmpropertycreatebitmask(dev, 0, name, props, ARRAYSIZE(props), supportedrotations); } diff --git a/drivers/gpu/drm/i915/inteldisplay.c b/drivers/gpu/drm/i915/inteldisplay.c index 050b249..bab17fd 100644 --- a/drivers/gpu/drm/i915/inteldisplay.c +++ b/drivers/gpu/drm/i915/inteldisplay.c @@ -10401,7 +10401,7 @@ static void intelcrtcinit(struct drmdevice *dev, int pipe) if (INTELINFO(dev)->gen >= 4) { if (!devpriv->rotationproperty) devpriv->rotationproperty = - drmmodecreaterotationproperty(dev, + drmmodecreaterotationproperty(dev, "rotation", BIT(DRMROTATE0) | BIT(DRMROTATE180)); if (devpriv->rotationproperty) diff --git a/drivers/gpu/drm/i915/intelsprite.c b/drivers/gpu/drm/i915/intelsprite.c index 7dcce4e..2936007 100644 --- a/drivers/gpu/drm/i915/intelsprite.c +++ b/drivers/gpu/drm/i915/intelsprite.c @@ -1216,7 +1216,7 @@ intelplaneinit(struct drmdevice *dev, enum pipe pipe, int plane) if (!devpriv->rotationproperty) devpriv->rotationproperty = - drmmodecreaterotationproperty(dev, + drmmodecreaterotationproperty(dev, "rotation", BIT(DRMROTATE0) | BIT(DRMROTATE180)); diff --git a/drivers/gpu/drm/omapdrm/omapplane.c b/drivers/gpu/drm/omapdrm/omapplane.c index e4a3fd1..72b9dc7 100644 --- a/drivers/gpu/drm/omapdrm/omapplane.c +++ b/drivers/gpu/drm/omapdrm/omapplane.c @@ -300,7 +300,7 @@ void omapplaneinstallproperties(struct drmplane *plane, if (priv->hasdmm) { prop = priv->rotationprop; if (!prop) { - prop = drmmodecreaterotationproperty(dev, + prop = drmmodecreaterotationproperty(dev, "rotation", BIT(DRMROTATE0) | BIT(DRMROTATE90) | BIT(DRMROTATE180) | BIT(DRMROTATE270) | BIT(DRMREFLECTX) | BIT(DRMREFLECTY)); diff --git a/include/drm/drmcrtc.h b/include/drm/drmcrtc.h index e1c0aba..ee84a4a 100644 --- a/include/drm/drmcrtc.h +++ b/include/drm/drmcrtc.h @@ -1185,6 +1185,7 @@ extern int drmformathorzchromasubsampling(uint32t format); extern int drmformatvertchromasubsampling(uint32t format); extern const char *drmgetformatname(uint32t format); extern struct drmproperty *drmmodecreaterotationproperty(struct drmdevice *dev, + const char *name, unsigned int supportedrotations); extern unsigned int drmrotationsimplify(unsigned int rotation, unsigned int supportedrotations);

More information about the dri-devel mailing list