[RFC PATCH v3 1/9] staging: imx-drm-core: don't request probe deferral in imx_drm_encoder_parse_of (original) (raw)
Philipp Zabel p.zabel at pengutronix.de
Tue Feb 18 03:36:02 PST 2014
- Previous message: [RFC PATCH v3 0/9] imx-drm dt bindings
- Next message: [RFC PATCH v3 1/9] staging: imx-drm-core: don't request probe deferral in imx_drm_encoder_parse_of
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
From: Lucas Stach <l.stach at pengutronix.de>
Since imx_drm_encoder_parse_of is called from the encoder bind callbacks, it is too late to request probe deferral. Rather the core should make sure that the crtcs are bound before the encoders, after all needed components are probed.
This fixes probe failure when using the LDB on i.MX6.
Signed-off-by: Lucas Stach <l.stach at pengutronix.de> Signed-off-by: Philipp Zabel <p.zabel at pengutronix.de>
drivers/staging/imx-drm/imx-drm-core.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c index dcba518..98a97a2 100644 --- a/drivers/staging/imx-drm/imx-drm-core.c +++ b/drivers/staging/imx-drm/imx-drm-core.c @@ -457,21 +457,13 @@ int imx_drm_encoder_parse_of(struct drm_device *drm, return ret; id = args.args_count > 0 ? args.args[0] : 0; - mask = imx_drm_find_crtc_mask(imxdrm, args.np, id); + crtc_mask |= imx_drm_find_crtc_mask(imxdrm, args.np, id); of_node_put(args.np);
/** If we failed to find the CRTC(s) which this encoder is* supposed to be connected to, it's because the CRTC has* not been registered yet. Defer probing, and hope that* the required CRTC is added later.*/if (mask == 0)return -EPROBE_DEFER;crtc_mask |= mask; }
- if (i == 0 || !crtc_mask)
return -ENOENT;encoder->possible_crtcs = crtc_mask; /* FIXME: this is the mask of outputs which can clone this output. */
-- 1.8.5.3
- Previous message: [RFC PATCH v3 0/9] imx-drm dt bindings
- Next message: [RFC PATCH v3 1/9] staging: imx-drm-core: don't request probe deferral in imx_drm_encoder_parse_of
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]