[PATCH] drm/radeon: TTM must be init with cpu-visible VRAM, v2 (original) (raw)
Christian König deathsimple at vodafone.de
Fri Feb 28 11:56:26 PST 2014
- Previous message: [PATCH] drm/radeon: TTM must be init with cpu-visible VRAM, v2
- Next message: [PATCH] drm/radeon: TTM must be init with cpu-visible VRAM, v2
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Am 28.02.2014 19:50, schrieb Lauri Kasanen:
Without this, a bo may get created in the cpu-inaccessible vram. Before the CP engines get setup, all copies are done via cpu memcpy.
This means that the cpu tries to read from inaccessible memory, fails, and the radeon module proceeds to disable acceleration. Doing this has no downsides, as the real VRAM size gets set as soon as the CP engines get init. This is a candidate for 3.14 fixes. v2: Add comment on why the function is used Signed-off-by: Lauri Kasanen <cand at gmx.com>
Reviewed-by: Christian König <christian.koenig at amd.com>
And I suggest to add "Cc: stable at vger.kernel.org" as well.
Christian.
--- drivers/gpu/drm/radeon/radeonttm.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/radeon/radeonttm.c b/drivers/gpu/drm/radeon/radeonttm.c index 3aa853c..b966f85 100644 --- a/drivers/gpu/drm/radeon/radeonttm.c +++ b/drivers/gpu/drm/radeon/radeonttm.c @@ -715,6 +715,9 @@ int radeonttminit(struct radeondevice *rdev) DRMERROR("Failed initializing VRAM heap.\n"); return r; } + /* Change the size here instead of the init above so only lpfn is affected */ + radeonttmsetactivevramsize(rdev, rdev->mc.visiblevramsize); + r = radeonbocreate(rdev, 256 * 1024, PAGESIZE, true, RADEONGEMDOMAINVRAM, NULL, &rdev->stollenvgamemory);
- Previous message: [PATCH] drm/radeon: TTM must be init with cpu-visible VRAM, v2
- Next message: [PATCH] drm/radeon: TTM must be init with cpu-visible VRAM, v2
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]