[LLVMdev] lld coding style (original) (raw)
Zachary Turner zturner at google.com
Thu Oct 9 00:24:05 PDT 2014
- Previous message: [LLVMdev] lld coding style
- Next message: [LLVMdev] lld coding style
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
I'm not sure the LLD style is appropriate either, as Chandler points out earlier starting variables with underscores is too close to underfined behavior. I might actually propose adopting lldb's style of an m_ prefix for members, g_ prefix for globals, and no_prefix for everything else. LLDB is going to be your hardest sell on migrating towards LLVM coding standards, so migrating towards them will at least help close the gap, and possible make it easier to get LLDB members to agree to migrate towards LLVM on other points.
On Wed, Oct 8, 2014 at 9:31 PM, Chris Lattner <clattner at apple.com> wrote:
On Oct 8, 2014, at 4:58 PM, Nick Kledzik <kledzik at apple.com> wrote: > Yes, having uniforms coding styles is nice. Therefore, I suggest we discuss a variable naming convention that fixes LLVM's problems and can be adopted by all projects.
Yes, I think this is reasonable: I care primarily about consistency, not about which option is picked. Please start a thread, proposing that we change the LLVM style to follow the LLD style (and outline the pros and cons of the style). If the community decides that changing LLVM/Clang to follow LLD is the right thing to do, than so be it. Until we get consensus, I agree that it makes sense to hold off on renaming the world in LLD. -Chris
LLVM Developers mailing list LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141009/4a968919/attachment.html>
- Previous message: [LLVMdev] lld coding style
- Next message: [LLVMdev] lld coding style
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]