[llvm-dev] change in CMake variable names breaks existing uses and does not conform to CMake conventions (original) (raw)

Chris Bieneman via llvm-dev llvm-dev at lists.llvm.org
Thu Sep 1 10:25:50 PDT 2016

Brad King brought this up on the commit thread, and I replied telling him I would bring back the old names.

The reason behind the change is that we’re currently blurring the lines between in-tree and out-of-tree builds, and we need to have consistent interfaces for projects.

Either way, both names are supported with r280380.

-Chris

On Sep 1, 2016, at 5:03 AM, Mueller-Roemer, Johannes Sebastian via llvm-dev <llvm-dev at lists.llvm.org> wrote:

Hi Philip, thanks for the hint about the man page. Totally forgot about that. Even though Config-mode generally has different rules, we don’t truly support that anyways as none of the exported targets have the INTERFACEINCLUDEDIRECTORIES (in which case the LLVMINCLUDEDIRS variable would become unnecessary anyways). Regards, Johannes From: Philip Pfaffe [mailto:philip.pfaffe at gmail.com] Sent: Thursday, September 1, 2016 14:01 To: Mueller-Roemer, Johannes Sebastian <Johannes.Sebastian.Mueller-Roemer at igd.fraunhofer.de> Cc: Chris Bieneman (cbieneman at apple.com) <cbieneman at apple.com>; llvm-dev at lists.llvm.org Subject: Re: [llvm-dev] change in CMake variable names breaks existing uses and does not conform to CMake conventions Hi Everyone, (resending because I can't get the hang of Reply All) I second Johannes. cmake's own Find* man page suggests using the DIRS variant "to keep things consistent": https://cmake.org/cmake/help/git-master/manual/cmake-developer.7.html#standard-variable-names <https://cmake.org/cmake/help/git-master/manual/cmake-developer.7.html#standard-variable-names> Granted, we're supporting Config-mode and not Module-mode, but i think the variable name rules should still apply for consistency. Best Philip 2016-09-01 13:31 GMT+02:00 Mueller-Roemer, Johannes Sebastian via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>: Hi Chris and everyone else, I just noticed that some of my builds broke due to commit 280013, as LLVMINCLUDEDIRS was renamed to LLVMINCLUDEDIR. In and of itself, not much of an issue as the fix is just to remove one character (in a couple of places). However, I would like to discuss if this rename is desirable at all. Sure, in-tree LLVMINCLUDEDIR is used everywhere, however not providing an ${NAME}INCLUDEDIRS variable goes against CMake conventions. See for example the find scripts included with CMake itself: https://cmake.org/cmake/help/v3.6/module/FindZLIB.html <https://cmake.org/cmake/help/v3.6/module/FindZLIB.html> -> provides ZLIBINCLUDEDIRS (and not ZLIBINCLUDEDIR) even though it is typically only one directory And the same holds true for most other Find${NAME}.cmake scripts I had a look at (Boost, Bullet, CUDA, Freetype, XMLRPC, Zlib). I’ll admit there are 1 or 2 exceptions (such as OpenGL) but in general I think it would be better to stick to the more common/conventional case. Thoughts? Regards Johannes

Fraunhofer-Institut für Graphische Datenverarbeitung IGD Fraunhoferstr. 5 | 64283 Darmstadt | Germany Tel +49 6151 155-606 tel:%2B49%206151%20155-606 | Fax +49 6151 155-139 tel:%2B49%206151%20155-139 johannes.mueller-roemer at igd.fraunhofer.de <mailto:johannes.mueller-roemer at igd.fraunhofer.de> | www.igd.fraunhofer.de <http://www.igd.fraunhofer.de/>

LLVM Developers mailing list llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev>

LLVM Developers mailing list llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160901/d763af33/attachment.html>

More information about the llvm-dev mailing list