[llvm-dev] Should intrinsics llvm.eh.sjlj.setjmp be with isBarrier flag? (original) (raw)

Zheng CZ Chen via llvm-dev llvm-dev at lists.llvm.org
Sun Dec 9 17:39:44 PST 2018

Thanks for your reply.

Patch is created https://reviews.llvm.org/D55499.

Thanks.

BRS// Chen Zheng Power Compiler Backend Developer

From: Tim Northover <t.p.northover at gmail.com> To: czhengsz at cn.ibm.com Cc: LLVM Developers Mailing List <llvm-dev at lists.llvm.org> Date: 2018/12/08 06:07 PM Subject: Re: [llvm-dev] Should intrinsics llvm.eh.sjlj.setjmp be with isBarrier flag?

On Fri, 7 Dec 2018 at 18:25, Zheng CZ Chen via llvm-dev <llvm-dev at lists.llvm.org> wrote:

Is there any misunderstanding? Is there any specification reason for setting llvm.eh.sjlj.setjmp as a barrier?

I agree with you, the setjmp ones shouldn't be isBarrier. I suspect the original commit mistook the name "isBarrier" as referring to a memory fence-like construct. It's a fairly common mistake and could easily apply here.

Cheers.

Tim.

-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20181210/a741d0cd/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: graycol.gif Type: image/gif Size: 105 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20181210/a741d0cd/attachment.gif>

More information about the llvm-dev mailing list