[llvm-dev] Improving textual IR format for nameless blocks (original) (raw)
Reid Kleckner via llvm-dev llvm-dev at lists.llvm.org
Fri Feb 22 13:57:09 PST 2019
- Previous message: [llvm-dev] Improving textual IR format for nameless blocks
- Next message: [llvm-dev] Improving textual IR format for nameless blocks
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Thanks so much for making this happen. I have written many, many clang test cases with convoluted FileCheck regexes that match "label:" and "; :" so they pass with and without NDEBUG.
On Fri, Feb 22, 2019 at 7:34 AM James Y Knight via llvm-dev < llvm-dev at lists.llvm.org> wrote:
After watching a few different people get confused about nameless blocks in llvm IR, and recalling my own confusion a few years ago, I'd like to change the syntax slightly to make it a bit clearer.
This is similar to the change made for instruction names in https://llvm.org/PR2480 a decade ago. Two changes: 1. Change the parsing of a numeric block label to parse as a value number rather than a string. 2. When printing blocks, always print the value number as a proper label, except for the initial block. See proposed change in https://reviews.llvm.org/D58548
LLVM Developers mailing list llvm-dev at lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190222/a7b3f025/attachment.html>
- Previous message: [llvm-dev] Improving textual IR format for nameless blocks
- Next message: [llvm-dev] Improving textual IR format for nameless blocks
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]