[llvm-dev] Removing LLVM_ALWAYS_INLINE from ADT classes (original) (raw)

Nico Weber via llvm-dev llvm-dev at lists.llvm.org
Thu Jan 17 11:25:23 PST 2019

On Thu, Jan 17, 2019 at 2:17 PM David Greene <dag at cray.com> wrote:

Alex Bradbury via llvm-dev <llvm-dev at lists.llvm.org> writes:

> As mentioned elsewhere in the thread, building TableGen with > Debug+Asserts isn't only useful for people who want to debug TableGen > itself. It's useful for anybody modifying .td as many checks on .td > input are only run in an asserts build. If there is a desire to move > to LLVMOPTIMIZEDTABLEGEN by default I think the correct next step is > to write up a separate RFC on this, detailing the advantages, > disadvantages, and potential paths forward. One of the obvious path > forwards is to put development effort into ensuring that tablegen > doesn't need asserts enabled in order to catch invalid inputs. +1. This is exactly the reason I'm nervous about making LLVMOPTIMIZEDTABLEGEN on by default. As someone who does a fair amount of .td twiddling and also occasionally hacks on TableGen itself, I almost never build it optimized.

Maybe LLVM_OPTIMIZED_TABLEGEN could do Release+Asserts builds?

(I don't have any opinion on anything here, just throwing out ideas)

-David -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190117/b7e87476/attachment.html>

More information about the llvm-dev mailing list