[llvm-dev] Removing LLVM_ALWAYS_INLINE from ADT classes (original) (raw)

via llvm-dev llvm-dev at lists.llvm.org
Fri Jan 18 08:52:37 PST 2019

-----Original Message----- From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of David Greene via llvm-dev Sent: Thursday, January 17, 2019 2:56 PM To: Nico Weber Cc: llvm-dev Subject: Re: [llvm-dev] Removing LLVMALWAYSINLINE from ADT classes

Nico Weber <thakis at chromium.org> writes: > +1. This is exactly the reason I'm nervous about making > LLVMOPTIMIZEDTABLEGEN on by default. As someone who does a fair > amount of .td twiddling and also occasionally hacks on TableGen > itself, I almost never build it optimized. > > Maybe LLVMOPTIMIZEDTABLEGEN could do Release+Asserts builds? > > (I don't have any opinion on anything here, just throwing out ideas) When I'm hacking on TableGen, I frequently run it in a debugger and anything that degrades that experience is problematic. Ideally we'd have better debugging experiences with optimized code but we're not there yet. TableGen should probably be reworked to not require asserts enabled to detect bad input. That just seems really wrong. This would allow more use of LLVMOPTIMIZEDTABLEGEN but I personally would still want a debug build to build a debug TableGen for use with a debugger.

Personally I avoid TableGen like the plague, but its attitude towards asserts does seem really wrong, and counter to how the rest of the project works: Asserts should verify internal consistency, and can be turned off with a -Asserts build; bad user input should get a diagnostic, regardless of the build mode. --paulr

-David

LLVM Developers mailing list llvm-dev at lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

More information about the llvm-dev mailing list