Review Request 111938: Allow installing both qca2 and qca3 (original) (raw)
Ivan Romanov drizt at land.ru
Thu Sep 5 18:49:48 UTC 2013
- Previous message: Review Request 111938: Allow installing both qca2 and qca3
- Next message: Review Request 111938: Allow installing both qca2 and qca3
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Sept. 1, 2013, 5:16 p.m., David Faure wrote: > Looks fine to me.
I don't agree with this patch. I didn't get any notification about this. So I very ask you before do any changes in cmake rules talk with me. It is important for me.
- Ivan
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111938/#review39088
On Sept. 3, 2013, 12:42 p.m., Alexander Richardson wrote:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111938/ ----------------------------------------------------------- (Updated Sept. 3, 2013, 12:42 p.m.)
Review request for KDE Frameworks and Ivan Romanov. Description ------- Use qt5 suffix for files by default when installing a Qt5 version of QCA This way coinstallation of Qt4 and Qt5 based QCA is possible by default Diffs ----- CMakeLists.txt 8cff977 src/CMakeLists.txt 037c9ff src/config-qca.h.cmake PRE-CREATION src/qcaplugin.cpp ad810b9 Diff: http://git.reviewboard.kde.org/r/111938/diff/ Testing ------- Compiled and installed. creating a Qt5 package for openSuSE works fine Thanks, Alexander Richardson
-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130905/7528ef4a/attachment.html>
- Previous message: Review Request 111938: Allow installing both qca2 and qca3
- Next message: Review Request 111938: Allow installing both qca2 and qca3
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the Kde-frameworks-devel mailing list