Review Request 111938: Allow installing both qca2 and qca3 (original) (raw)

Christophe Giboudeaux cgiboudeaux at gmx.com
Sat Sep 7 19:56:18 UTC 2013

On Sept. 1, 2013, 5:16 p.m., David Faure wrote: > Looks fine to me.

Ivan Romanov wrote: I don't agree with this patch. I didn't get any notification about this. So I very ask you before do any changes in cmake rules talk with me. It is important for me. David Faure wrote: Holy... and here I was, thinking I was doing something good by reviewing patches for QCA, for lack of reviewers/maintainers. Fine, I will definitely stay out of QCA completely, it's not like I ever wanted to be involved with it. It's all yours now. When objecting to a patch, you might want to give a more detailed technical argumentation than "I don't agree", BTW. But I don't care anymore for that argumentation, that's a discussion between you and Alexander. About notifications: you were in the CC for the request, according to reviewboard. You might want to check which emails reviewboard has for you, or your mail setup. Ivan Romanov wrote: Bad ides was to change default values. Now Gentoo building broken also ... yestarday we was building QCA for Qt5 on Windows and couldn't understand why it was installing to "C:\Program Files" and had -qt5 suffix. So Alexander please revert 1. QCAINSTALLINQTPREFIX default value 2. QCALIBSUFFIX defalut value 3. QCAINCLUDEINSTALLDIR and QCAPRIVATEINCLUDEINSTALLDIR in case when QCAINSTALLINQTPREFIX == OFF. Also what for LIBINSTALLDIR has different values for Qt4 and Qt5? When I was writing this rules I want to reach the purposes of: 1. Easy installing when building manually. 2. Good adjustability to satisfy any needs. David. Thanks for review and thanks for your care Qca. Ivan Romanov wrote: Alexander, I discussed question about QCAINSTALLINQTPREFIX with David. So, I agree to use QCAINSTALLINQTPREFIX=ON only when CMAKEINSTALLPREFIX is not defined. Furthemore I want to use QCAINSTALLINQTPREFIX as non-cache entry. It's mean that by default for installing will be used Qt prefix, if user defined CMAKEINSTALLPREFIX this folder will be used. If user want to install in /usr/local he must do 'cmake -DCMAKEINSTALLPREFIX=/usr/local'. Yes, I do. I know that /usr/local is Unix tradition. And now I consciously break this. Package maintainers always use CMAKEINSTALLPREFIX, default path is important only for people how build for themself. If someone want to build for himself he will prefer Qt prefix. Anyway I very doubt that he want to install in /usr/local, more likely he will use CMAKEINSTALLPREFIX with other path. So /usr/local is the most rarely case. David Faure wrote: +1. This seems to be the best solution. Christophe Giboudeaux wrote: No no no, you completely ignored what I said yesterday. QCAINSTALLINQTPREFIX must be OFF by default without condition, and that was fixed with this review request. > So, I agree to use QCAINSTALLINQTPREFIX=ON only when CMAKEINSTALLPREFIX is not defined. That just won't work, CMAKEINSTALLPREFIX will always be defined. This can be verified very simply: project(test) cmakeminimumrequired(VERSION 2.8.9 FATALERROR) if(DEFINED CMAKEINSTALLPREFIX) message(STATUS "PREFIX: ${CMAKEINSTALLPREFIX}") endif() Running 'cmake -DCMAKEINSTALLPREFIX="/foo"' will return "/foo" Just running 'cmake' will return "/usr/local" Please just add a README.PACKAGERS file giving information about the qca options.

Ivan Romanov wrote: if(DEFINED CMAKEINSTALLPREFIX) message(STATUS "PREFIX: ${CMAKEINSTALLPREFIX}") endif() project(test) cmakeminimumrequired(VERSION 2.8.9 FATALERROR) [taurus at localhost test]$ cmake . -- The C compiler identification is GNU 4.8.1 -- The CXX compiler identification is GNU 4.8.1 -- Check for working C compiler: /usr/bin/cc -- Check for working C compiler: /usr/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ -- Check for working CXX compiler: /usr/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Configuring done -- Generating done -- Build files have been written to: /home/taurus/develop/free-lance/hamster-tz/icons/test [taurus at localhost test]$ cmake -DCMAKEINSTALLPREFIX=/usr/local . -- PREFIX: /usr/local -- Configuring done -- Generating done -- Build files have been written to: /home/taurus/develop/free-lance/hamster-tz/icons/test Ivan Romanov wrote: I didn't ignore you. I just didn't see solid reasons to use /usr/local by default. I am looking for a way to satisfy everbody. Also I want to satisfy myself. Ivan Romanov wrote: [taurus at localhost test]$ rm -fr CMakeCache.txt CMakeFiles cmakeinstall.cmake Makefile [taurus at localhost test]$ cmake -DCMAKEINSTALLPREFIX=/usr/local . -- PREFIX: /usr/local -- The C compiler identification is GNU 4.8.1 -- The CXX compiler identification is GNU 4.8.1 -- Check for working C compiler: /usr/bin/cc -- Check for working C compiler: /usr/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ -- Check for working CXX compiler: /usr/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Configuring done -- Generating done -- Build files have been written to: /home/taurus/develop/free-lance/hamster-tz/icons/test

Forget /usr/local, that's not the problem. It's the default value that CMake will use if no installation prefix is given. The issue is your option: I'm repeating: "QCA_INSTALL_IN_QT_PREFIX must be OFF by default" or said differently, never install anything outside CMAKE_INSTALL_PREFIX unless this option is enabled and you will make everyone happy.

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111938/#review39088

On Sept. 3, 2013, 12:42 p.m., Alexander Richardson wrote:

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111938/ ----------------------------------------------------------- (Updated Sept. 3, 2013, 12:42 p.m.)

Review request for KDE Frameworks and Ivan Romanov. Description ------- Use qt5 suffix for files by default when installing a Qt5 version of QCA This way coinstallation of Qt4 and Qt5 based QCA is possible by default Diffs ----- CMakeLists.txt 8cff977 src/CMakeLists.txt 037c9ff src/config-qca.h.cmake PRE-CREATION src/qcaplugin.cpp ad810b9 Diff: http://git.reviewboard.kde.org/r/111938/diff/ Testing ------- Compiled and installed. creating a Qt5 package for openSuSE works fine Thanks, Alexander Richardson

-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130907/b590290c/attachment-0001.html>

More information about the Kde-frameworks-devel mailing list