Review Request 112702: KIO slavebase listEntry improvement and cleanups (original) (raw)

Mark Gaiser markg85 at gmail.com
Sat Sep 14 22:29:50 UTC 2013

On Sept. 14, 2013, 10:45 a.m., David Faure wrote: > kioslave/file/fileunix.cpp, line 336 > <http://git.reviewboard.kde.org/r/112702/diff/1/?file=189210#file189210line336> > > seems to me that it should be indented even more? > > > Anyhow, yes, commit the indentation fixes separately (without a new reviewboard request)

Fixed: http://commits.kde.org/kdelibs/54bef748783455af114aaaac2cdfdf2f964ec7c1

On Sept. 14, 2013, 10:45 a.m., David Faure wrote: > staging/kio/src/core/slavebase.h, line 23 > <http://git.reviewboard.kde.org/r/112702/diff/1/?file=189211#file189211line23> > > I'm pretty sure it was included already, via one of the kio/* includes below. You can just remove this.

It's odd, it (QtCreator) does underline it in red (as if it can't find it) when i remove that line. But compiling seems to be working just fine. So it's removed now.

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112702/#review40015

On Sept. 12, 2013, 6:26 p.m., Mark Gaiser wrote:

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112702/ ----------------------------------------------------------- (Updated Sept. 12, 2013, 6:26 p.m.)

Review request for KDE Frameworks and kdelibs. Description ------- This patch actually does two things: 1. A small indentation fix that this diff doesn't show properly (i can commit that as a separate commit if that's preferred) 2. A cleanup in how a listDir is handled. It used to be required to send a listEntry(UDSEntry, true) to indicate that the listing is completed. Then the UDSEntry was skipped. It seemed vague to me so i deprecated that function and added a new listEntry that doesn't take a bool. Now you just have to call finished() when done listing. finished() was already required otherwise KIO would blame you with warnings :) Diffs ----- kioslave/file/fileunix.cpp 48bd0ba staging/kio/src/core/slavebase.h b46631e staging/kio/src/core/slavebase.cpp 2e46985 Diff: http://git.reviewboard.kde.org/r/112702/diff/ Testing ------- It compiles and runs just fine. The few tests that are there are passing though i doubt they test this case. the KIO file slave also works just fine. Compilation does give me new (expected deprecated errors for at least the http slave. I don't know how to test that one. It should just work fine though. Thanks, Mark Gaiser

-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130914/28b67f1f/attachment-0001.html>

More information about the Kde-frameworks-devel mailing list