[OpenJDK 2D-Dev] [PATCH FOR REVIEW] fix for bug 8011693: Remove redundant fontconfig files (original) (raw)

Andrew Hughes gnu.andrew at redhat.com
Wed May 29 12:06:23 UTC 2013

----- Original Message -----

On 05/20/2013 04:37 PM, Jiri Vanek wrote: > On 05/10/2013 04:08 PM, Jiri Vanek wrote: >> On 04/08/2013 05:31 PM, Jiri Vanek wrote: >>> On 04/08/2013 04:13 PM, Vladislav Karnaukhov wrote: >>>> Hello Jiri, >>>> >>>> please see inline. >>>> >>>> On 4/8/2013 05:29 PM, Jiri Vanek wrote: >>>>> On 04/08/2013 02:39 PM, Vladislav Karnaukhov wrote: >>>>> >>>>> Thank you very much for win-check! It will force me to install new >>>>> windows machine somewhere. >>>>> Do you mind do check if pure removal of fontconfig files (both src and >>>>> bfc) from you installed jdk7/8 on windows will work? (should) >>>> >>>> Yes, I've checked and it does not work. That's the reason why I >>>> replied to your very first >>>> message. A removal of fontconfig.* files simply crashes Java, - on both >>>> Windows and Mac, - because >>>> some font management-related classes rely on these files. Hence my >>>> question regarding deeper >>>> re-design on font management system... >>>> >>>> I've tested Mac build as well, and there's the same error: >>> >>> Ok. I will try anyway:) >>> For linux I'm quite sure the new fontmanagers are working pretty fine. >>> Do you think it will be acceptable to prepare smaller clean up - to >>> remove all linux fontconfig >>> files? >>> >>> And later, as separate changeset to fontmanagers for windows/mac, but >>> I'm afraid I will not be >>> capable of such an development on non linux system. >>> >>> Thanx for your help, >>> >>> J. >>>> >> >> Hi! >> >> I had finally found some free time, so here it is - smaller version which >> is removing just stuff for >> linux when OpenJDK is defined. >> >> http://jvanek.fedorapeople.org/oracle/jdk8/webrevs/removedFontConfigFiles-linuxOnly/ >> >> Although I had windows build, I lost this machine so - again (and sorry >> for that) - tested only on >> Fedora. >> >> Also when I read the individual fontmanagers, I believe that they really >> should work without >> fontocfigs. So although this is fixing the 8011693, new bugs should be >> filled for windows and mac, >> because theirs implementations are broken. >> >> Thank you very much for any comments. >> >> Best Regards >> j. > >

Ping? Any advice how to move this forward? > > I know that this is minor fix compared to others I can read on this > channel, but as the font > managers exists, and fontconfig files should be redundant, then this > change should be done. If > fontmanagers are buggy (and eg windows one appeared to be) then as soon as > this will be tempted then > sooner it will get fixed. > > For linux I'm pretty sure this is working, and we have even removed the > fontconfig files from > packages in public facing version three months ago [1] > > So this can be first step to get rid of old and redundant font mapping > completely. > > > J. > > > [1] > http://pkgs.fedoraproject.org/cgit/java-1.7.0-openjdk.git/commit/?h=f17&id=9d6dd62ae2123635b4d15e40e527a0b617756484 > > (search for +rm %{buildoutputdir}/j2re-image/lib/fontconfig)

I've applied this patch and built OpenJDK, and it went fine. A basic Swing application still loads up fine.

So looks good to go to me.

Andrew :)

Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07

More information about the 2d-dev mailing list