[OpenJDK 2D-Dev] [9] Review Request: 8032219 [macosx] Scrollbars looks bad under retina in Motif and Metal L&F (original) (raw)

Jim Graham james.graham at oracle.com
Fri Apr 4 21:16:33 UTC 2014

The new code in SwingUtilities2 looks good to me, so I'll approve that file. I'll leave the code in the rest of the files to Petr...

        ...jim

On 4/4/14 6:37 AM, Sergey Bylokhov wrote:

Hello. Please review the fix for jdk 9.

The problem became visible, when we draw a border across the component using drawLine, and expected that fillRect will clear a border of the component. This is incorrect, because in case of the scaled graphics(retina) some part of the line can be placed outside of the rectangles bounds. See additional information here: https://bugs.openjdk.java.net/browse/JDK-8011764 In the fix new methods were added to draw the lines using fillRect. Bug: https://bugs.openjdk.java.net/browse/JDK-8032219 Webrev can be found at: http://cr.openjdk.java.net/~serb/8032219/webrev.03 -- Best regards, Sergey.

More information about the 2d-dev mailing list