[OpenJDK 2D-Dev] [9] Review Request: 8039418 [macosx] Calling JNI functions in the scope of Get/ReleasePrimitiveArrayCritical (original) (raw)
Andrew Brygin andrew.brygin at oracle.com
Thu Apr 10 05:12:33 UTC 2014
- Previous message: [OpenJDK 2D-Dev] [9] Review Request: 8039418 [macosx] Calling JNI functions in the scope of Get/ReleasePrimitiveArrayCritical
- Next message: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8039862: Fix fallthrough lint warnings in 2d
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hello Sergey,
the fix looks fine to me.
Thanks, Andrew
On 4/9/2014 1:21 AM, Sergey Bylokhov wrote:
Hello. Please review the fix for jdk 9. The method [1] is called between Get/ReleasePrimitiveArrayCritical. In the fix it was moved above GetPrimitiveArrayCritical call.
[1]: JNIEXPORT void JNICALL TransformGetInfo(JNIEnv *env, jobject txform, TransformInfo *pTxInfo) { pTxInfo->dxdx = (*env)->GetDoubleField(env, txform, m00ID); pTxInfo->dxdy = (*env)->GetDoubleField(env, txform, m01ID); pTxInfo->tx = (*env)->GetDoubleField(env, txform, m02ID); pTxInfo->dydx = (*env)->GetDoubleField(env, txform, m10ID); pTxInfo->dydy = (*env)->GetDoubleField(env, txform, m11ID); pTxInfo->ty = (*env)->GetDoubleField(env, txform, m12ID); } Bug: https://bugs.openjdk.java.net/browse/JDK-8039418 Webrev can be found at: http://cr.openjdk.java.net/~serb/8039418/webrev.00
- Previous message: [OpenJDK 2D-Dev] [9] Review Request: 8039418 [macosx] Calling JNI functions in the scope of Get/ReleasePrimitiveArrayCritical
- Next message: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8039862: Fix fallthrough lint warnings in 2d
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]