[8] Review request for 7186371: [macosx] Main menu shortcuts not displayed (7u6 regression) (original) (raw)
Sergey Bylokhov Sergey.Bylokhov at oracle.com
Thu Aug 9 00:46:11 PDT 2012
- Previous message: [8] Review request for 7161437: [macosx] awt.FileDialog doesn't respond appropriately for mac when selecting folders
- Next message: [8] Review request for 7161437: [macosx] awt.FileDialog doesn't respond appropriately for mac when selecting folders
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
09.08.2012 06:09, J.S. Ferguson wrote:
Seems to fix the menu visual problem, but now actions are firing twice when the accelerator is used as described in bug 7160951.
http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7160951 Yes this bug on our radar. On Aug 7, 2012, at 4:39 AM, Sergey Bylokhov wrote:
Hi Everyone, Please review the fix. When we translate calls from our swing menu components to awt peer we resets information about shortcut in the setLabel(). This happens because of ScreenMenuItem.setAccelerator() method call peers setLabel(..,..,..) directly and does not initialize ScreenMenuItem.shortcut property. But default implementation of ScreenMenuItem.setLabel() assumes that this field(shortcut) will be initialized.
This works on jdk6 because it does not reset shortcut if null or empty shortcut is provided. As a solution we can use peers methods directly in both cases. Bug: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7186371 Webrev can be found at: http://cr.openjdk.java.net/~serb/7186371/webrev.00 -- Best regards, Sergey.
-- Best regards, Sergey.
- Previous message: [8] Review request for 7161437: [macosx] awt.FileDialog doesn't respond appropriately for mac when selecting folders
- Next message: [8] Review request for 7161437: [macosx] awt.FileDialog doesn't respond appropriately for mac when selecting folders
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]