[8] Review request for 7153339: InternalError when drawLine with Xor and Antialiasing (original) (raw)
Oleg Pekhovskiy oleg.pekhovskiy at oracle.com
Fri Aug 10 14:29:42 PDT 2012
- Previous message: hg: jdk8/awt/jdk: 18 new changesets
- Next message: hg: jdk8/awt/jdk: 7161437: [macosx] awt.FileDialog doesn't respond appropriately for mac when selecting folders
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi!
Please review the fix for CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7153339
Webrev: http://cr.openjdk.java.net/~bagiras/8/7153339.1/
Comments: XOR mode is not supported for D3D (see comments inside D3DSurfaceData.validatePipe()) and software rendering is used instead invalidating current D3DSurfaceData. So we have situation when component's peer has invalid SurfaceData and it's retrieved in SunGraphics2D.revalidateAll() through SurfaceData.getReplacement() without any check. That's why I added validity check there.
Thanks, Oleg
<http://cr.openjdk.java.net/%7Ebagiras/8/7153339.1/>
- Previous message: hg: jdk8/awt/jdk: 18 new changesets
- Next message: hg: jdk8/awt/jdk: 7161437: [macosx] awt.FileDialog doesn't respond appropriately for mac when selecting folders
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]