[8] Review request for 7172187 [macosx] JAWT native CALayer not positioned over Canvas (original) (raw)
Anthony Petrov anthony.petrov at oracle.com
Tue Aug 14 07:40:47 PDT 2012
- Previous message: [8] Review request for 7172187 [macosx] JAWT native CALayer not positioned over Canvas
- Next message: 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
+1.
-- best regards, Anthony
On 8/14/2012 6:39 PM, Artem Ananiev wrote:
Looks fine. Thanks, Artem On 8/14/2012 6:30 PM, Sergey Bylokhov wrote: Hi Everyone, Please review the fix. Description of main changes:
CPlatformComponent.java: -Unused peer and target references were removed. -Wrong return value for nativeSetBounds() was changed from long to void. AWTSurfaceLayers.m: -layer.bounds was replaced by layer.frame, because layer.bounds doesn't honour x and y position of the layer. -Wrong position inversion was removed. Also related fields were marked as volatile, if they were used in the different threads + javadoc cleanup. Bug: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7172187 Webrev can be found at: http://cr.openjdk.java.net/~serb/7172187/webrev.00 -- Best regards, Sergey.
- Previous message: [8] Review request for 7172187 [macosx] JAWT native CALayer not positioned over Canvas
- Next message: 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]