[8] Review request for 7186109: Simplify lock machinery for PostEventQueue & EventQueue (original) (raw)

Oleg Pekhovskiy oleg.pekhovskiy at oracle.com
Fri Aug 17 05:49:21 PDT 2012

• Previous message: 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call
• Next message: [8] Review request for 7186109: Simplify lock machinery for PostEventQueue & EventQueue
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi!

Please review the fix for CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7186109

Webrev: http://cr.openjdk.java.net/~bagiras/8/7186109.1/

The following changes were made:

1. Removed flushLock from SunToolkit.flushPendingEvent()
2. Returned method PostEventQueue.flush() as 'synchronized' back
3. Added call of SunToolkit.flushPendingEvents() to EventQueue.detachDispatchThread(), right before pushPopLock.lock()
4. Removed !SunToolkit.isPostEventQueueEmpty() check from EventQueue.detachDispatchThread()
5. Removed SunToolkit.isPostEventQueueEmpty() & PostEventQueue.noEvents();

Thanks, Oleg <http://cr.openjdk.java.net/%7Ebagiras/8/7186109.1/>

• Previous message: 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call
• Next message: [8] Review request for 7186109: Simplify lock machinery for PostEventQueue & EventQueue
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the awt-dev mailing list