[8] Review request for 7160609: [macosx] JDK crash in libjvm.dylib ( C [GeForceGLDriver+0x675a] gldAttachDrawable+0x941) (original) (raw)

Artem Ananiev artem.ananiev at oracle.com
Thu Aug 23 07:05:42 PDT 2012

Hi, Anthony,

I've got one minor comment about the second version of the fix. The code in LWWindowPeer and CPlatformWindow looks pretty strange now: we always pass (1, 1) as (minWidth, minHeight) and then query target component for real minimum size. I would suggest to call target.isMinSizeSet() and target.getMinSize() in LWWindowPeer, and make CPlatformWindow.setSizeConstraints() as straightforward as possible.

Thanks,

Artem

On 8/22/2012 3:58 PM, Anthony Petrov wrote:

Hi Sergey,

Thanks for the review. Please find my comments and a new version of the fix inline. On 8/21/2012 8:03 PM, Sergey Bylokhov wrote: Looks like this code is not necessary in jdk8 any more:

673 // Re-apply the size constraints and the size to ensure the space 674 // occupied by the grow box is counted properly 675 peer.updateMinimumSize(); There are two reasons I don't want to remove this code now: 1. This same fix needs to be back-ported to 7u8 where this code is required. 2. After changing the resizable style, native OS may or may not reset or somehow affect the maximum/minimum sizes of a window, and/or its real current size. This had best be investigated under a separate CR for JDK 8. 21.08.2012 20:01, Sergey Bylokhov пишет: Hi,Anthony. I guess that getMinimumSize() in the setSizeConstraints should be wrapped with isMinimumSizeSet like it was in LWWindowsPeer, same for getMaximumSize() This makes sense even though the old code didn't do that in CPW.setMinimumSize(). Here's an updated webrev: http://cr.openjdk.java.net/~anthony/8-40-hugeWindowCrash-7160609.1/ -- best regards, Anthony

21.08.2012 18:35, Anthony Petrov wrote: Hi Artem and Sergey,

Please review a fix for http://bugs.sun.com/viewbug.do?bugid=7160609 at: http://cr.openjdk.java.net/~anthony/8-40-hugeWindowCrash-7160609.0/ Since OpenGL fails to create a square texture of size GLMAXTEXTURESIZE, we use the total screen bounds to limit possible window sizes on the Mac. Note that this behavior is consistent with the constraints imposed by the native OS on MS Windows, so this mustn't look like a Mac-only JDK limitation. -- best regards, Anthony

More information about the awt-dev mailing list