[8] Review request for 7190587 Open source and jtreg'ify JAWT regression test (original) (raw)

Anthony Petrov anthony.petrov at oracle.com
Tue Aug 28 05:42:49 PDT 2012

Hi Konstantin,

I think you should modify the copyright headers in each file. The files are no longer proprietary/confidential. .sh and makefiles should also include a copyright header. Please use existing source files in the open repository as a template for the header.

test/java/awt/JAWT/MyCanvas.java

52 f.show();

Please replace this with f.setVisible(true);

53 robot.delay(10000);

I think 10 seconds is kind of too long. It might have been relevant for Java 1.4, but now I think 5 seconds should be pretty much enough for every modern system.

test/java/awt/JAWT/JAWT.sh

137 case "$OS" in 138 Windows* | CYGWIN* ) 139 cp TESTJAVA{TESTJAVA}TESTJAVA{FS}jre${FS}bin${FS}jawt.dll . 140 ;; 141 esac

Why is this necessary? This must be a bug in JDK if the library still needs to be copied to the current directory on Windows. Could you verify if the test still works w/o copying the dll? It must, actually.

-- best regards, Anthony

On 8/27/2012 8:29 PM, Konstantin Shefov wrote:

Hello,

Please review a fix for the issue: 7190587 Open source and jtreg'ify JAWT regression test Test was modified in to be run with jtreg. The webrev is http://cr.openjdk.java.net/~kshefov/7190587/webrev.00/

Thanks, Konstantin

More information about the awt-dev mailing list