[7u8] Review request for 7171045 [macosx] There are no enter or exit events reported against 8b39 for MouseEventsDuringDrag. (original) (raw)
Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Tue Aug 28 05:57:13 PDT 2012
- Previous message: hg: jdk8/awt/jdk: 7186371: [macosx] Main menu shortcuts not displayed (7u6 regression)
- Next message: [7u8] Review request for 7171045 [macosx] There are no enter or exit events reported against 8b39 for MouseEventsDuringDrag.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hello,
Please review the fix for the JDK 7u8: bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171045 webrev: http://cr.openjdk.java.net/~alexsch/7171045/webrev7.00/
This is a regression after the fix 7154048 [macosx] At least drag twice, the toolbar can be dragged to the left side.
In the case where a toolbar is created under a mouse and it is dragged over the initial window the mouse enter/exit events should not be generated for the components which are under the toolbar. The disabling component mouse enter/exit events generation during drag leads that it does not work in the case where a mouse is dragged over the current window.
The full fix that checks that a current window is a topmost window under mouse requires some changes (using tracking area instead of tracking rectangle and so on) is a quite complicated and it seems that it is risky to include it to the JDK 7u8.
Current fix just changes the condition for the component mouse enter/exit events generation to the initial state how it was before the 7154048 fix.
This allows to generate components mouse enter/exit events, but the following test will fail: java/awt/Mouse/EnterExitEvents/DragWindowTest.java However this test did not work before the 7154048 fix so it is not a regression.
Thanks, Alexandr.
- Previous message: hg: jdk8/awt/jdk: 7186371: [macosx] Main menu shortcuts not displayed (7u6 regression)
- Next message: [7u8] Review request for 7171045 [macosx] There are no enter or exit events reported against 8b39 for MouseEventsDuringDrag.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]