[8] Review request for 7123476: DesktopOpenTests:When enter the file path and click the open button, it crash (original) (raw)

Anthony Petrov anthony.petrov at oracle.com
Wed Feb 1 09:03:59 PST 2012

Hi Denis,

The gtk_show_uri() is available since GTK 2.14. Did you verify if all platforms supposed to be supported by JDK 8 have this version of GTK libraries installed by default? I'm mostly concerned about Solaris systems, as well as corporate Linux desktops. If this is not the case, then perhaps using this function should be conditional, and with the old GTK library we should fall back to using the old API. You may notice that, for example, for the file chooser we have an explicit check for GTK 2.8.0 and use the new gtk_file_chooser_set_do_overwrite_confirmation() API only when it's available.

I like that we move all the GTK-related utility code to the gtk2_interface files. A few comments:

  1. Please use the TRUE and FALSE constants instead of 1 and 0 as a return value for gtk2_show_uri_load().

  2. Should the fprintf() call be #ifdef'ed for INTERNAL_BUILD's only?

-- best regards, Anthony

On 2/1/2012 7:39 PM, Denis S. Fokin wrote:

Hi AWT team,

Please review a fix for the CR 7123476 at http://cr.openjdk.java.net/~denis/7123476/webrev.01 CR URL: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7123476 The Gnome API is deprecated so we need to migrate on GTK function. See the next thread. http://mail.gnome.org/archives/gnome-devel-list/2009-January/msg00004.html Thank you, Denis.

More information about the awt-dev mailing list