Code Review Request for CR 7143070 (original) (raw)
Code Review Request for CR 7143070 - test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java freezes on exit
Anthony Petrov anthony.petrov at oracle.com
Wed Feb 8 05:32:03 PST 2012
- Previous message: Code Review Request for CR 7143070 - test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java freezes on exit
- Next message: hg: jdk8/awt/jdk: 7132367: [macosx] ChoiceMouseWheelTest should be adapted for mac toolkit
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Oleg,
Thanks for the webrev!
60 if(!ret) 61 throw new RuntimeException("Test failed!");
Please add a space after 'if' and put the throw statement into a {} block.
Otherwise the fix looks good to me.
-- best regards, Anthony
On 2/8/2012 4:56 PM, Oleg Pekhovskiy wrote:
Hi guys,
here is the fix for: http://bugs.sun.com/viewbug.do?bugid=7143070 webrev: http://cr.openjdk.java.net/~denis/7143070/webrev.03/ <http://cr.openjdk.java.net/%7Edenis/7143070/webrev.03/> The main idea was eliminate test freezing on exit for some systems. So synchronization between threads on exit was rewritten. Thanks, Oleg
- Previous message: Code Review Request for CR 7143070 - test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java freezes on exit
- Next message: hg: jdk8/awt/jdk: 7132367: [macosx] ChoiceMouseWheelTest should be adapted for mac toolkit
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]