Request for review: 7155298 : Editable TextArea blocks GUI application from exit (original) (raw)

Sean Chou zhouyx at linux.vnet.ibm.com
Wed Mar 21 05:07:17 PDT 2012

Hi Anthony,

Thanks for the suggestion, I didn't notice that. The timeout would

simplify the testcase much, I'll rewrite it.

On Wed, Mar 21, 2012 at 7:36 PM, Anthony Petrov <anthony.petrov at oracle.com>wrote:

Hi Sean,

The code changes look fine to me. However, I see an issue with the test. It seems to verify a concrete implementation rather than the expected behavior. Since disposing a text area prevents an app from exiting w/o your fix, perhaps exactly this needs to be tested? We don't want to use reflection to access specific fields in peer classes, and then verify their internal state. Actually, after calling dispose() and returning from main() a jtreg test would simply fail by time out, and that would indicate a regression. With your fix applied, however, the test would correctly exit, and thus pass. -- best regards, Anthony

On 3/21/2012 11:55 AM, Sean Chou wrote: Hi all,

It is found that when TextArea or TextField is setEditable(true), the application will not exit after the application frame disposes. The reason is the visible caret contains a timer which controls its flashing . This timer must be stopped when disposing. Link to webrev: http://cr.openjdk.java.net/~**zhouyx/7155298/webrev.00/<http://cr.openjdk.java.net/%7Ezhouyx/7155298/webrev.00/> Link to bug: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7155298<http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7155298> -- Best Regards, Sean Chou

-- Best Regards, Sean Chou -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20120321/17b9d1d2/attachment.html

More information about the awt-dev mailing list