Code Review Request for CR 7146237 (original) (raw)
Code Review Request for CR 7146237 - closed/java/awt/Focus/SetFocusTraversalKeysTest/SetFocusTraversalTest.html failed since 1.8.0b19
Anthony Petrov anthony.petrov at oracle.com
Fri Mar 30 09:22:01 PDT 2012
- Previous message: Code Review Request for CR 7146237 - closed/java/awt/Focus/SetFocusTraversalKeysTest/SetFocusTraversalTest.html failed since 1.8.0b19
- Next message: [8] Request for review: 7124401 [macosx] After call Frame dispose() application continues to work
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks great!
-- best regards, Anthony
On 3/30/2012 8:16 PM, Oleg Pekhovskiy wrote:
Hi Anthony,
thank you for this clarification, I modified those places: http://cr.openjdk.java.net/~bagiras/8/7146237.2 Thanks, Oleg. 3/30/2012 2:06 PM, Anthony Petrov wrote: Hi Oleg,
The "modern" tagging approach for the javadoc is to use {@code ...} instead of
...
. Otherwise the changes look fine to me. -- best regards, Anthony On 3/29/2012 7:09 PM, Oleg Pekhovskiy wrote: Hi guys,please review these java-doc changes for: http://bugs.sun.com/viewbug.do?bugid=7146237 webrev: http://cr.openjdk.java.net/~bagiras/8/7146237.1 Thanks, Oleg
- Previous message: Code Review Request for CR 7146237 - closed/java/awt/Focus/SetFocusTraversalKeysTest/SetFocusTraversalTest.html failed since 1.8.0b19
- Next message: [8] Request for review: 7124401 [macosx] After call Frame dispose() application continues to work
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]