[8] Review request for 7142091: [macosx] RFE: Refactoring of peer initialization/disposing (original) (raw)
Sergey Bylokhov Sergey.Bylokhov at oracle.com
Thu May 31 06:43:46 PDT 2012
- Previous message: Review request for 6891269 non-compliance with Section 508 using 1.6.0_18
- Next message: [8] Review request for 6868690 TEST: java/awt/FontClass/CreateFont/BigFont.java test should be modified in jdk7&8 to run via jtreg
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Everyone, Please review the fix.
Notes from the bug and comments:
setVisible() should be called at the end of the peers initialization. We can move super.initialize() to the end of the peers initializations. Initialize() was split to initialize() and initializeImpl(). In the initialize() we call initializeImpl and then we call to setVisible(). initializeImpl overridden in subclasses.
Invokelater in the initialization/disposing is a tricky. Left it as is. Probably later it will be changed. Comments was updated.
replaceSurfacedata() should be moved outside of LWWindowPeer.setVisible() Done. Also duplicate code was extracted to setVisible() method which call setVisibleImpl().
Backbuffer in replaceSurfacedata() should be initialized by clearRect instead of fillrect(composite is important). Done. related to composite.
During lwwindowpeer initialization we call two similar methods nativeSetNSWindowAlpha() and setAlphaValue(). nativeSetNSWindowAlpha() removed from CPlatformWindow.java.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142091 Webrev can be found at: http://cr.openjdk.java.net/~serb/7142091/webrev.00/
-- Best regards, Sergey.
- Previous message: Review request for 6891269 non-compliance with Section 508 using 1.6.0_18
- Next message: [8] Review request for 6868690 TEST: java/awt/FontClass/CreateFont/BigFont.java test should be modified in jdk7&8 to run via jtreg
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]