[8] Please review fix for 7175183: [macosx] Objective-C exception thrown when switching monitor configuration (original) (raw)
Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue Sep 4 04:08:59 PDT 2012
- Previous message: [8] Please review fix for 7175183: [macosx] Objective-C exception thrown when switching monitor configuration
- Next message: [8] Please review fix for 7175183: [macosx] Objective-C exception thrown when switching monitor configuration
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi, Alexander. I think that it should be reviewed on 2d alias.
But a few comments:
- It is unclear how getBackupSurface can set sdAccel to null, but if it set, it should invalidate old surface.
- Same question about CWrapper: if pointer contains nil do we release this object before?
04.09.2012 13:48, Alexander Zuev wrote:
Hello,
please review my fix for CR 7175183: [macosx] Objective-C exception thrown when switching monitor configuration The NPE happens because of the getBackupSurface method call results in the resetting of the current surface to null. The idea of the fix is to check for it in both native and java methods before using it. Bug description is: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7175183 Webrev can be found here: http://cr.openjdk.java.net/~kizune/7175183/webrev.00 With best regards, Alex
-- Best regards, Sergey.
- Previous message: [8] Please review fix for 7175183: [macosx] Objective-C exception thrown when switching monitor configuration
- Next message: [8] Please review fix for 7175183: [macosx] Objective-C exception thrown when switching monitor configuration
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]