[8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display (original) (raw)
Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Apr 8 06:10:21 PDT 2013
- Previous message: [8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display
- Next message: [OpenJDK 2D-Dev] [8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi, Phil, JIm. New version of the fix: http://cr.openjdk.java.net/~serb/8000629/webrev.08
- Assumption that we should scale all native surfaces was wrong. In case of managed Bufferedimage we shouldn't scale native surface, because they are copies 1-1.(CGLSurfaceData.java:60).
- BufferedContext is not always updates current Paint, because it checks transX/transY from sg2d, which is not maintained in the scale mode. Test: FillTexturePaint.java
Also I found a problem in the sg2d.getTransform(), where invScale does not apply to constrainX/Y. Test: TransformSetGet.java
On 4/5/13 10:00 PM, Phil Race wrote:
SFAIK you haven't fixed the problem with TexturePaint I pointed out last week. That needs to be fixed before you push.
-phil. On 4/5/2013 9:54 AM, Sergey Bylokhov wrote: Hi, Jim. I assume, that you haven't additional comments? Can I consider you as the second reviewer? Note that I plan push it to awt-dev because, my other fixes depend on it.
On 3/26/13 7:33 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk 8. Change adds initial support of hidpi(mostly on 2d side). In the fix scale was added to the surface data/CGraphicsDevice /CGLLayer. This scale factor maps virtual coordinates to physical pixels. This change doesn't add support of hidpi to aqua l&f and doesn't add support of dynamic change of scale factor.
Bug: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=8000629 Webrev can be found at: http://cr.openjdk.java.net/~serb/8000629/webrev.06 -- Best regards, Sergey. -- Best regards, Sergey.
-- Best regards, Sergey.
-------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130408/448ecd5a/attachment.html
- Previous message: [8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display
- Next message: [OpenJDK 2D-Dev] [8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]