Approved: [8] Request for review: 7194902 and 7181403 (original) (raw)
Phil Race philip.race at oracle.com
Fri Feb 22 09:11:16 PST 2013
- Previous message: Approved: [8] Request for review: 7194902 and 7181403
- Next message: [8] Request for approval for CR 7161759 - TEST_BUG: java/awt/Frame/WindowDragTest/WindowDragTest.java fails to compile, should be modified
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Sergey (B), I assume you updated the test with the bug ID ? That's the normal convention as a test uncovers a regression to indicate which test to run to verify the fix.
In this case the failing test is in "closed" so I can't see it here to verify you did this I know we have a backlog of such tests still to move Perhaps if you'd moved it to "open" at the same time it would be easier.
-phil.
On 2/22/2013 8:14 AM, Sergey Bylokhov wrote:
Hi, Sergey. The bug(7194902) was found by the test.
22.02.2013 19:47, Sergey Malenkov wrote: The fix looks good. Is it possible to create a test to ensure that the correct button is used?
Thanks, SAM On 13.02.2013 18:42, Sergey Bylokhov wrote: cc swing-dev
Hello, Please review the fix for jdk 8. convertMouseEvent should use correct button info instead of NOBUTTON + small cleanup. Bugs: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7194902 http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7181403 Webrev can be found at: http://cr.openjdk.java.net/~serb/7194902/webrev.00/
- Previous message: Approved: [8] Request for review: 7194902 and 7181403
- Next message: [8] Request for approval for CR 7161759 - TEST_BUG: java/awt/Frame/WindowDragTest/WindowDragTest.java fails to compile, should be modified
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]