[8] Request for review: 8003169: [macosx] JVM crash after disconnecting from projector (original) (raw)
Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Thu Feb 28 07:57:19 PST 2013
- Previous message: [8] Request for review: 8003169: [macosx] JVM crash after disconnecting from projector
- Next message: Review Request for 8006941 : [macosx] Deadlock in drag and drop & 7199783 : Setting cursor on DragSourceContext does not work on OSX
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
The fix looks good for me.Thanks, Alexandr.
On 2/26/2013 5:45 PM, Sergey Bylokhov wrote:
Hello, Please review the fix for jdk 8. Fix will be ported to jdk7 as well.
In the fix getScreenInsets() implementation was moved to the one native method. I assume that it doesn't lead to incorrect nsscreen in the middle of operations, if we run all appropriate operation in one step on appkit thread. CFRetain/CFRelease are unnecessary in this case. nativeGetDisplay** methods were changed to static, because in the native they implemented as a static. Bug: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=8003169 Webrev can be found at: http://cr.openjdk.java.net/~serb/8003169/webrev.00
- Previous message: [8] Request for review: 8003169: [macosx] JVM crash after disconnecting from projector
- Next message: Review Request for 8006941 : [macosx] Deadlock in drag and drop & 7199783 : Setting cursor on DragSourceContext does not work on OSX
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]