Review Request for JDK-8013468 [macosx] Cursor does not update properly when in fullscreen mode on Mac (original) (raw)
Anthony Petrov anthony.petrov at oracle.com
Mon Jun 10 07:21:43 PDT 2013
- Previous message: Review Request for JDK-8013468 [macosx] Cursor does not update properly when in fullscreen mode on Mac
- Next message: hg: jdk8/awt/jdk: 7105030: [TEST_BUG] [macosx] The tests never finishes
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks good to me. A minor suggestion: please declare the mouseEnterCount in the test as volatile to ensure both threads operate on the same value. No need for a new webrev with this change.
-- best regards, Anthony
On 06/10/13 15:24, Petr Pchelko wrote:
Hello, AWT Team.
Please review the fix for the issue: http://bugs.sun.com/viewbug.do?bugid=8013468 The webrev is available at: http://cr.openjdk.java.net/~pchelko/8013468/webrev.01/ The reason of this issue is in the fact that MOUSEENTERED events do not come when the window goes fullscreen. I have updated the logic for synthesizing these events. I have added a regression test for this problem. This change also fixes another regression test: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java With best regards. Petr.
- Previous message: Review Request for JDK-8013468 [macosx] Cursor does not update properly when in fullscreen mode on Mac
- Next message: hg: jdk8/awt/jdk: 7105030: [TEST_BUG] [macosx] The tests never finishes
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]