Add version information to jvmti demos. (original) (raw)

Zhengyu Gu zhengyu.gu at oracle.com
Thu Sep 15 16:14:28 UTC 2011

No progress been made. Any reason should be resolved right away?

Thanks,

-Zhengyu

On 9/15/2011 2:50 AM, Sean Chou wrote:

Hi, About this bug, is there any progressing ?

2011/6/8 Zhengyu Gu <zhengyu.gu at oracle.com <mailto:zhengyu.gu at oracle.com>> No, I did not make any progress on 6988099, as it was deferred to JDK8. With Dan's comment, looks good to me. Thanks, -Zhengyu On 6/7/2011 12:10 PM, Daniel D. Daugherty wrote: Adding Zhengyu since he is the RE on 6988099 and I'm not sure if he is on the serviceability-dev alias... Zhengyu, I don't know if you have a fix already in process for this issue or not. Comments on the Makefile change below. Dan On 6/6/2011 8:59 PM, David Holmes wrote: Sean, Because this is a JVMTI demo it falls under serviceability, so I've cc'ed that list. David Sean Chou said the following on 06/07/11 12🔞 Is there any comment ? 2011/5/26 Sean Chou <zhouyx at linux.vnet.ibm.com_ _<mailto:zhouyx at linux.vnet.ibm.com> <mailto:zhouyx at linux.vnet.ibm.com_ _<mailto:zhouyx at linux.vnet.ibm.com>>> Hi all, I made a simple patch for bug http://bugs.sun.com/bugdatabase/viewbug.do?bugid=6988099 (jvmti demos missing Publisher (COMPANY resource) in dll and exe files on windows) . Will anyone have a look at my patch ? Thanks. diff --git make/common/Demo.gmk make/common/Demo.gmk index a3788ae..8c43cf9 100644 --- make/common/Demo.gmk +++ make/common/Demo.gmk @@ -158,6 +158,7 @@ ifneq ($(strip $(DEMOALLNATIVESOURCES)),) # bit between them. LINK.demo = $(LINK.c) LDLIBS.demo = $(EXTRALIBS) $(LFLAGS$(COMPILERVERSION)) + DEMOVERSIONINFO = (OBJDIR)/(OBJDIR)/(OBJDIR)/(LIBRARY).res else ifneq ($(DEMONEEDSCPP),) LINK.demo = $(LINK.cpp) @@ -288,6 +289,13 @@ ifndef DEMOSKIPSRCZIP $(install-file) endif The change below is not bracketed by "ifeq ($(PLATFORM),windows)" but it certainly looks Windows specific. +# JDK name required here _+RCFLAGS += /D "JDKFNAME=$(LIBRARY).dll" _ _+ /D "JDKINTERNALNAME=$(LIBRARY)" _ + /D "JDKFTYPE=0x2L" + + + # Native library building ifdef DEMOLIBRARY @@ -308,8 +316,11 @@ $(OBJDIR)/%.$(OBJECTSUFFIX): $(DEMOBUILDSRCDIR)/%.cpp # Actual creation of the native shared library (C++ and C are different) $(DEMOLIBRARY): $(DEMOFULLOBJECTS) @$(prep-target) + ifeq ($(PLATFORM),windows) + (RC)(RC) (RC)(RCFLAGS) $(CCOBJECTOUTPUTFLAG)$(DEMOVERSIONINFO) $(VERSIONINFORESOURCE) + endif $(LINK.demo) $(SHAREDLIBRARYFLAG) _$(CCPROGRAMOUTPUTFLAG)$@ _ - (DEMOFULLOBJECTS)(DEMOFULLOBJECTS) (DEMOFULLOBJECTS)(LDLIBS.demo) + (DEMOFULLOBJECTS)(DEMOFULLOBJECTS) (DEMOFULLOBJECTS)(LDLIBS.demo) $(DEMOVERSIONINFO) The above change uses "$(DEMOVERSIONINFO)" but that variable is only set under "ifeq ($(PLATFORM),windows)" above. That won't break make, but I wanted to be sure that was intentional. @$(call binaryfileverification,$@) # Generation of any javah include file, make sure objects are dependent on it

-- Best Regards, Sean Chou

-- Best Regards, Sean Chou

-- Best Regards, Sean Chou -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://mail.openjdk.org/pipermail/build-dev/attachments/20110915/7a392a7b/attachment.htm>

More information about the build-dev mailing list