Code review request for Linux DEBUG_BINARIES/FDS fix (7188168) (original) (raw)

Daniel D. Daugherty daniel.daugherty at oracle.com
Thu Aug 2 16:02:21 UTC 2012

Thanks Andrew!

Dan

On 8/2/12 9:53 AM, Andrew Hughes wrote:

----- Original Message ----- Greetings,

I have a fix for the following Linux specific FDS bug: 7188168 4/4 7071904 broke the DEBUGBINARIES option on Linux Here is the URL for the webrev: http://cr.openjdk.java.net/~dcubed/fdsrevamp/7188168-webrev/0/ What the fix does is reorder and slightly tweak the Makefile logic that supports the DEBUGBINARIES make option: - when 'DEBUGBINARIES=true' is specified, the '-g' option is added to the CFLAGS make variable and none of the other {DEBUG,FASTDEBUG,OPT}CFLAGS variables are touched - this fix prevents doubled '-g' options and combined '-g' and '-gstabs' options - depending on the particular Linux config being built, a compilation will have a single '-g' or a single '-gstabs' or neither of those options The Linux embedded builds doesn't support FDS yet so most of those compiles fall into the "neither" bucket... Thanks, in advance, for any reviews. Dan

Looks good to me. Makes it much clearer than the early version that DEBUGBINARIES effectively overrides everything else.

More information about the build-dev mailing list