[PATCH] Update RPATH to make loading libjawt possible (original) (raw)

Andrew Hughes ahughes at redhat.com
Fri Aug 10 12:24:36 UTC 2012

----- Original Message -----

Hi Anthony,

a. although this is a build change, I have requested Omair to provide a regression test, IMO if we had a regression test to begin with, this would not have been removed during the RPATH work. We may have to check in a ".so" for linux and solaris variants. So my question to you. Where should such a test be parked, in awt regression test hierarchy ? b. this should be pushed via awt integration repo, thus allowing all awt PITs to be run.

Please don't check binaries into the repositories. Omair's test works fine with just source code. I replicated the issue using it.

Thanks > Kumar > > Hi Omair, > > The fix looks good to me. I think Kumar needs to take a look at it, > too, before the fix can be pushed to a repo. > > Thanks for finding and fixing this issue. > > -- > best regards, > Anthony > > On 8/10/2012 1:48 AM, Omair Majid wrote: >> On 08/09/2012 07:15 AM, Andrew Hughes wrote: >>> ----- Original Message ----- >>>> Hi Kumar, >>>> >>>> On 07/23/2012 11:19 AM, Kumar Srinivasan wrote: >>>>> My suggestion is to see if System.loadLibrary can be used, this >>>>> will >>>>> bode well for the modularization effort. >>>> I discussed this with the folks at awt-dev and they would prefer >>>> to >>>> avoid loading as much as possible. They are strongly against >>>> always >>>> preloading libjawt.so. >>>> >>> For my 2c, I'm against it too. It doesn't seem the right fix. >> >> I can see your point, but both the solutions feel wrong to me. I >> can't >> make up my mind which is the less bad. >> >>> I don't see an attachment :-( >> >> I guess the mailing list software stripped it out. I did attach >> it. >> >>> Shouldn't it be a webrev anyway? >> >> Old habits :) >> >> Webrev is at: >> http://cr.openjdk.java.net/~omajid/webrevs/jawt-link-regression/00/ >> >> I have also put up a test case at: >> http://cr.openjdk.java.net/~omajid/jawt-test.tar.gz >> >> The test case is the exact same as that on >> http://download.java.net/jdk8/docs/technotes/guides/awt/AWTNativeInterface.html, >> >> except it automates the building and running. You will have to >> edit the >> makefile to set the value of JDKHOME. It should point to a >> j2sdk-image >> directory. >> >> Then do: >> $ make >> $ make run >> >> Without the fix it should print an UnsatisfiedLinkError. With the >> fix, >> it should show a window. >> >>> I built jdk8/build successfully just last week. What issues are >>> you >>> seeing? >> >> Errors building hotspot, I seem to recall. But I cant reproduce it >> anymore after pulling today. I can now confirm that the fix works >> for me >> with jdk8 too. >> >> Thanks, >> Omair >

Andrew :)

Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07

More information about the build-dev mailing list