[PATCH] Update RPATH to make loading libjawt possible (original) (raw)

Anthony Petrov anthony.petrov at oracle.com
Mon Aug 13 14:39:42 UTC 2012

The test looks great, and I like that it doesn't depend on the JAWT machinery, but tests the actual problematic RPATH entry only.

+1 from me.

-- best regards, Anthony

On 08/13/12 18:22, Kumar Srinivasan wrote:

Hi Anthony, Omair.

Here is the patch for the test, this will live in test/tools/launcher, also I don't have access to a MacOS system, appreciate if you can add this otherwise I will file a bug and add the macosx case later on. Thanks Kumar

Hi Omair and Kumar,

As to me, the fix and the test look good. A few suggestions: 1. Mac is also a supported platform now, so you need to add the "Darwin" option to the "SunOS | Windows* )" case in the .sh file. 2. If gcc is not present, this should be considered that the test is passed. Systems used for running tests may lack compilers, and this is perfectly OK. Having said that, let's wait and see what test Kumar has to offer. -- best regards, Anthony On 08/11/12 00:56, Omair Majid wrote: Hi Anthony,

On 08/10/2012 08:29 AM, Anthony Petrov wrote: Actually, if Omair has a good automatic jtreg test, we would be happy to get it checked in with this fix. Could we see a webrev for the test please? I have uploaded a new webrev that includes a test case too: http://cr.openjdk.java.net/~omajid/webrevs/jawt-link-regression/01/ The bug number in the jtreg test is entirely made up. Any thoughts for a better description or alternate locations for the test code? I can only run the test case on Linux, so that's what it's for. It needs gcc to build the native bits. The webrev is against jdk8/awt forest, if it matters. Thanks, Omair

More information about the build-dev mailing list