[PATCH] Update RPATH to make loading libjawt possible (original) (raw)

Kumar Srinivasan kumar.x.srinivasan at oracle.COM
Tue Aug 14 11:13:28 UTC 2012


I see your point. As I told you we'll be open-sourcing a JAWT-specific test under 7190587. This test already provides support for Linux, Solaris, and Windows platforms, and even does a little more than just loads the jawt library.

So it looks there's still some value in Kumar's test as well. Yes, it will need to be rewritten should we replace the RPATH mechanism with something else in the future. It's up to Kumar to decide whether he wants such test to be present in the repo. Personally, I don't mind.

I think we need a test in the launcher area, as a first line of defense, so as to ensure we don't have a regression, when Program.gmk is modified, noting that test/tools/launcher is part of the testset core.

As for Omair's jawt test I too don't see much value if we already have a duplicate elsewhere which will be moved to opensource.

So I am ok with the Omair's changes - (jawt test) + (launchers test). :)

Kumar

-- best regards, Anthony On 8/13/2012 7:04 PM, Omair Majid wrote: On 08/13/2012 10:39 AM, Anthony Petrov wrote:

The test looks great, and I like that it doesn't depend on the JAWT machinery, but tests the actual problematic RPATH entry only.

I generally go for tests that verify behaviour (that jawt-linked programs are working) rather than implementation details (which changed, for example, when we switched from LDLIBRARYPATH to RPATHS).

+1 from me. Yes, good to have something that guards us from changing something unintentionally. Looks fine to me too. Cheers, Omair



More information about the build-dev mailing list