[PATCH] Update RPATH to make loading libjawt possible (original) (raw)

Kumar Srinivasan kumar.x.srinivasan at oracle.COM
Tue Aug 14 21:04:05 UTC 2012

Hi Omair,

Thumbs up!. please let me know when you actually push I will set the CR, so that the integrator does not get confused, and I don't get awt push notifications.

And once again thanks for doing this...

Kumar

On 08/14/2012 07:13 AM, Kumar Srinivasan wrote:

I see your point. As I told you we'll be open-sourcing a JAWT-specific test under 7190587. This test already provides support for Linux, Solaris, and Windows platforms, and even does a little more than just loads the jawt library. Awesome. A test like that will be great to have! I have no issues with leaving my jawt test out if we are going to add better tests soon.

So it looks there's still some value in Kumar's test as well. Yes, it will need to be rewritten should we replace the RPATH mechanism with something else in the future. It's up to Kumar to decide whether he wants such test to be present in the repo. Personally, I don't mind. I think we need a test in the launcher area, as a first line of defense, so as to ensure we don't have a regression, when Program.gmk is modified, noting that test/tools/launcher is part of the testset core. As for Omair's jawt test I too don't see much value if we already have a duplicate elsewhere which will be moved to opensource. As long as this corner case is accounted for, I agree. So I am ok with the Omair's changes - (jawt test) + (launchers test). :) Updated webrev: http://cr.openjdk.java.net/~omajid/webrevs/jawt-link-regression/02/ Shall I go ahead and commit? Thanks, Omair

More information about the build-dev mailing list