[7u6] Request for approval for CR 7157855: jvisualvm.1 not included in binaries (original) (raw)

Seán Coffey sean.coffey at oracle.com
Tue Aug 21 11:37:46 UTC 2012

Looks fine to me but best to get an official jdk8 reviewer.

I presume the filter-out option on macosx becomes a no-op (on OpenJDK builds) some lines later : (Images.gmk)

264 JDK_MAN_PAGES := (filter−outjvisualvm.1,(filter-out jvisualvm.1, (filter−outjvisualvm.1,(JDK_MAN_PAGES))

On the subject of dual Makefile maintenance, are there plans to eventually remove the older/legacy makefile structure on 8? I haven't been monitoring that topic too closely.

regards, Sean.

On 21/08/2012 12:13, Andrew Hughes wrote:

Ah good catch. I didn't realise this was duplicated in the new build system.

http://cr.openjdk.java.net/~andrew/jvisualvm/webrev.02/ should deal with both cases. If this is ok, is there a preferred forest to push to? I've been testing against build, but can easily push it somewhere else.

More information about the build-dev mailing list